View Issue Details

Category
整備班:YAYA
SeverityminorReproducibilityalways 
Status closed 
Summary0000498: Error E0032 is sent as W0032, and therefore will always tell the dev that they need to specify messagetxt
DescriptionError E0032 is sent as W0032 instead, and so doesn't have an error message properly attached. You can test this by removing/renaming the request function and reloading the ghost.

YAYA Tc569-13
TagsNo tags attached.
Attach Tags
Attached Files
image.png (2,286 bytes)   
image.png (2,286 bytes)   

Activities

guest

2022-05-28 16:58

reporter   ~0001258

I should note: I have specified messagetxt in this case, all the other errors show correctly.

guest

2022-05-29 02:04

reporter   ~0001259

https://github.com/Taromati2/yaya-shiori/commit/5e9e72c321584e20a17adf0f0a63e793d53b612f

guest

2022-05-29 02:15

reporter   ~0001260

I'm wondering if need to add a judgment to yaya to deal with the situation where messagetxt loads successfully but some information is missing....
After all, this should be the time to: update messagetxt or contact the developer
�‍♂️

guest

2022-05-29 02:28

reporter   ~0001261

My goodness you are clever....
https://github.com/Taromati2/yaya-shiori/commit/e84769ef7eb76430d7e49aadba4141f2b299a44e
图片.png (10,434 bytes)   
图片.png (10,434 bytes)   
图片-2.png (3,759 bytes)   
图片-2.png (3,759 bytes)   

guest

2022-05-29 02:28

reporter   ~0001262

I think that would be a good idea. I have been very careful about updating my messagetxt each time I update YAYA, but I do think if someone were to forget to do that, this would be a confusing message.
This bug in particular caused quite a lot of confusion, since we were certain the messagetxt file was set correctly, so we weren't sure where the actual issue was for a while.

guest

2022-05-29 02:52

reporter   ~0001263

Sorry for all the confusion, haha, messagetxt was something I came up with on a whim when I was designing the multilingual architecture for yaya, so obviously it's still not mature
My original intention was to allow each ghost to choose their own messagetxt based on their language, and to make it easier for users of niche languages to translate yaya's error messages for developers of the same language
Well, after all I think it's too inconvenient to write all the language information in the dll, and I've always been a bit OCD when it comes to hard drive usage, so it would be nice if everyone only allocated hard drive space for the part they use, and if the ghost had no intention of displaying error messages at runtime, the developers could even remove the entire messagetxt at release.
The unexpected result is that most ghosts based on yaya have all the language files in the messagetxt folder, which makes me not know whether to cry or laugh

ponapalt

2022-05-29 09:09

administrator   ~0001264

The messagetxt related issues became so bothersome, so I finally decided embedding the whole thing in the DLL.
yaya.dll size increased by 35KB, but I think that increase of about 35 KB is completely meaningless for 2-3 digit Mbps network speed era.

https://github.com/ponapalt/yaya-shiori/releases

Issue History

Date Modified Username Field Change
2022-05-28 16:57 guest New Issue
2022-05-28 16:57 guest File Added: image.png
2022-05-28 16:58 guest Note Added: 0001258
2022-05-29 02:04 guest Note Added: 0001259
2022-05-29 02:15 guest Note Added: 0001260
2022-05-29 02:28 guest Note Added: 0001261
2022-05-29 02:28 guest File Added: 图片.png
2022-05-29 02:28 guest File Added: 图片-2.png
2022-05-29 02:28 guest Note Added: 0001262
2022-05-29 02:52 guest Note Added: 0001263
2022-05-29 09:09 ponapalt Assigned To => ponapalt
2022-05-29 09:09 ponapalt Status new => closed
2022-05-29 09:09 ponapalt Resolution open => fixed
2022-05-29 09:09 ponapalt Note Added: 0001264